I am trying to insert some data to SQL Server 2008 R2 by using JAP and HIBERNATE. Everything “works” except for that it’s very slow. To insert 20000 rows, it takes about 45 seconds, while a C# script takes about less than 1 second.
Any veteran in this domain can offer some helps? I would appreciate it a lot.
Update: got some great advices from the answers below, but it still doesn’t work as expected. Speed is the same.
Here is the updated persistence.xml:
<persistence version="2.0" xmlns="http://java.sun.com/xml/ns/persistence" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://java.sun.com/xml/ns/persistence http://java.sun.com/xml/ns/persistence/persistence_2_0.xsd"> <persistence-unit name="ClusterPersist" transaction-type="RESOURCE_LOCAL"> <provider>org.hibernate.ejb.HibernatePersistence</provider> <class>cluster.data.persist.sqlserver.EventResult</class> <exclude-unlisted-classes>true</exclude-unlisted-classes> <properties> <property name="javax.persistence.jdbc.url" value="jdbc:sqlserver://MYSERVER:1433;databaseName=MYTABLE" /> <property name="javax.persistence.jdbc.user" value="USER" /> <property name="javax.persistence.jdbc.password" value="PASSWORD" /> <property name="javax.persistence.jdbc.driver" value="com.microsoft.sqlserver.jdbc.SQLServerDriver" /> <property name="hibernate.show_sql" value="flase" /> <property name="hibernate.hbm2ddl.auto" value="update" /> <property name="hibernate.connection.provider_class" value="org.hibernate.service.jdbc.connections.internal.C3P0ConnectionProvider" /> <property name="hibernate.c3p0.max_size" value="100" /> <property name="hibernate.c3p0.min_size" value="0" /> <property name="hibernate.c3p0.acquire_increment" value="1" /> <property name="hibernate.c3p0.idle_test_period" value="300" /> <property name="hibernate.c3p0.max_statements" value="0" /> <property name="hibernate.c3p0.timeout" value="100" /> <property name="hibernate.jdbc.batch_size" value="50" /> <property name="hibernate.cache.use_second_level_cache" value="false" /> </properties> </persistence-unit>
And here is the updated code part:
public static void writeToDB(String filePath) throws IOException { EntityManager entityManager = entityManagerFactory.createEntityManager(); Session session = (Session) entityManager.getDelegate(); Transaction tx = session.beginTransaction(); int i = 0; URL filePathUrl = null; try { filePathUrl = new URL(filePath); } catch (MalformedURLException e) { filePathUrl = (new File(filePath)).toURI().toURL(); } String line = null; BufferedReader stream = null; try { InputStream in = filePathUrl.openStream(); stream = new BufferedReader(new InputStreamReader(in)); // Read each line in the file MyRow myRow = new MyRow(); while ((line = stream.readLine()) != null) { String[] splitted = line.split(","); int num1 = Integer.valueOf(splitted[1]); float num2= Float.valueOf(splitted[6]).intValue(); myRow.setNum1(num1); myRow.setNum2(num2); session.save(myRow); if (i % 50 == 0) { session.flush(); session.clear(); } i++; } tx.commit(); } finally { if (stream != null) stream.close(); } session.close(); }
Updated, here is the source for MyRow:
@Entity @Table(name="MYTABLE") public class MyRow { @Id @GeneratedValue(strategy=GenerationType.IDENTITY) private Long id; @Basic @Column(name = "Num1") private int Num1; @Basic @Column(name = "Num2") private float Num2; public Long getId() { return id; } public void setId(Long id) { this.id = id; } public float getNum1() { return Num1; } public void setNum1(float num1) { Num1 = num1; } public int getNum2() { return Num2; } public void setNum2(int num2) { Num2 = num2; } }
Advertisement
Answer
To enable JDBC batching you should initialize the property hibernate.jdbc.batch_size to between 10 and 50 (int only)
hibernate.jdbc.batch_size=50
If it’s still not as fast as expected, then I’d review the document above paying attention to NOTE(s) and section 4.1. Especially the NOTE that says, “Hibernate disables insert batching at the JDBC level transparently if you use an identity identifier generator.”